wombatu-kun commented on PR #18497: URL: https://github.com/apache/hudi/pull/18497#issuecomment-4241996228
The three added tests (`testFloatVectorRoundTrip`, `testDoubleVectorRoundTrip`, `testMultipleVectorColumns`) are good writer/reader guards but cover only the trivial insert + full-table-read path. Recommended additions: - Nullable vector column (null row values, null whole struct). - Partitioned table. - MOR log merging (write → update → read). - Schema evolution: add VECTOR column to an existing Lance table and read old + new rows. - Clustering: verify clustered output Lance files also carry native `FixedSizeList` + footer. - Projection: read only the vector column; read vector column alongside metadata columns. - Time travel / incremental query. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
