n3nash commented on a change in pull request #2374:
URL: https://github.com/apache/hudi/pull/2374#discussion_r569193815
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -403,30 +439,32 @@ protected void postCommit(HoodieTable<T, I, K, O> table,
HoodieCommitMetadata me
// Delete the marker directory for the instant.
new MarkerFiles(table, instantTime).quietDeleteMarkerDir(context,
config.getMarkersDeleteParallelism());
- // Do an inline compaction if enabled
- if (config.isInlineCompaction()) {
- runAnyPendingCompactions(table);
- metadata.addMetadata(HoodieCompactionConfig.INLINE_COMPACT_PROP,
"true");
- inlineCompact(extraMetadata);
- } else {
- metadata.addMetadata(HoodieCompactionConfig.INLINE_COMPACT_PROP,
"false");
- }
+ if (config.isInlineTableServiceEnabled()) {
+ // Do an inline compaction if enabled
+ if (config.isInlineCompaction()) {
+ runAnyPendingCompactions(table);
+ metadata.addMetadata(HoodieCompactionConfig.INLINE_COMPACT_PROP,
"true");
+ inlineCompact(extraMetadata);
+ } else {
+ metadata.addMetadata(HoodieCompactionConfig.INLINE_COMPACT_PROP,
"false");
+ }
- // Do an inline clustering if enabled
- if (config.isInlineClustering()) {
- runAnyPendingClustering(table);
- metadata.addMetadata(HoodieClusteringConfig.INLINE_CLUSTERING_PROP,
"true");
- inlineCluster(extraMetadata);
- } else {
- metadata.addMetadata(HoodieClusteringConfig.INLINE_CLUSTERING_PROP,
"false");
- }
+ // Do an inline clustering if enabled
Review comment:
Intellij says ok, not sure why it's appearing this way here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
