vinothchandar commented on a change in pull request #2500:
URL: https://github.com/apache/hudi/pull/2500#discussion_r569700819
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java
##########
@@ -107,6 +107,8 @@
// Header metadata for a log block
private final Map<HeaderMetadataType, String> header = new HashMap<>();
private SizeEstimator<HoodieRecord> sizeEstimator;
+ // denotes GCSFileSystem
+ private boolean isGCSFileSystem;
Review comment:
lets not leak this into the handle classes. these should strictly be
storage agnostic
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
