vinothchandar commented on a change in pull request #2476:
URL: https://github.com/apache/hudi/pull/2476#discussion_r569725483
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java
##########
@@ -96,19 +94,21 @@
private static final Logger LOG = LogManager.getLogger(UtilHelpers.class);
public static Source createSource(String sourceClass, TypedProperties cfg,
JavaSparkContext jssc,
- SparkSession sparkSession, SchemaProvider
schemaProvider, HoodieDeltaStreamerMetrics metrics) throws IOException {
-
+ SparkSession sparkSession, SchemaProvider
schemaProvider,
+ HoodieDeltaStreamerMetrics metrics) throws
IOException {
try {
- if (JsonKafkaSource.class.getName().equals(sourceClass)
- || AvroKafkaSource.class.getName().equals(sourceClass)) {
+ try {
Review comment:
Okay my bad. I understand what you tried to do now. So you have your own
source class, that implements has a constructor with the metrics argument.
I was thinking along the lines of having all sources take in the metrics
field. We can deal with that separately
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
