MyLanPangzi commented on a change in pull request #2526:
URL: https://github.com/apache/hudi/pull/2526#discussion_r569883592
##########
File path:
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -118,7 +120,7 @@ public HoodieTableMetaClient(Configuration conf, String
basePath, boolean loadAc
ConsistencyGuardConfig consistencyGuardConfig,
Option<TimelineLayoutVersion> layoutVersion,
String payloadClassName) {
LOG.info("Loading HoodieTableMetaClient from " + basePath);
- this.basePath = basePath;
+ this.basePath = FilenameUtils.separatorsToUnix(basePath);
Review comment:
If you do not add this line of code, the
org.apache.hudi.common.table.TestHoodieTableMetaClient#checkMetadata test will
not pass. because of
org.apache.hudi.common.testutils.HoodieCommonTestHarness#tempDir using
java.nio.file.Path, windows users cannot pass the test. but now the ci seems
like failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
