nsivabalan commented on a change in pull request #2296:
URL: https://github.com/apache/hudi/pull/2296#discussion_r570224021
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/AbstractHoodieWriteClient.java
##########
@@ -173,6 +173,10 @@ public boolean commitStats(String instantTime,
List<HoodieWriteStat> stats, Opti
public boolean commitStats(String instantTime, List<HoodieWriteStat> stats,
Option<Map<String, String>> extraMetadata,
String commitActionType, Map<String,
List<String>> partitionToReplaceFileIds) {
+ // Skip the empty commit
+ if (stats.isEmpty()) {
Review comment:
Guess this is code path when auto commit is disabled.
[Here](https://github.com/apache/hudi/blob/647e9faf255b9ae5796f513d13c769a8c87788d4/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java#L237)
is the path when autoCommit is set to true. May be we need to fix here as
well. But would be nice if we clean the commit property rather than just
returning( .requested, .inflight etc). Basically rollback this pending commit.
but let's hear @vinothchandar thoughts as well whether can we delay an empty
dataset to this extent or should we fail fast before itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
