yanghua commented on a change in pull request #2227:
URL: https://github.com/apache/hudi/pull/2227#discussion_r571428795
##########
File path:
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -156,15 +160,18 @@ public static long totalNewMessages(OffsetRange[] ranges)
{
private final HashMap<String, Object> kafkaParams;
private final TypedProperties props;
protected final String topicName;
+ private final KafkaResetOffsetStrategies autoResetValue;
public KafkaOffsetGen(TypedProperties props) {
this.props = props;
+
kafkaParams = new HashMap<>();
for (Object prop : props.keySet()) {
kafkaParams.put(prop.toString(), props.get(prop.toString()));
}
DataSourceUtils.checkRequiredProperties(props,
Collections.singletonList(Config.KAFKA_TOPIC_NAME));
topicName = props.getString(Config.KAFKA_TOPIC_NAME);
+ autoResetValue =
KafkaResetOffsetStrategies.valueOf(props.getString("auto.offset.reset",
Config.DEFAULT_AUTO_RESET_OFFSET.toString()).toUpperCase());
Review comment:
@liujinhui1994 any response?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
