yanghua commented on a change in pull request #2547:
URL: https://github.com/apache/hudi/pull/2547#discussion_r571834732
##########
File path: hudi-flink/src/main/java/org/apache/hudi/sink/CommitSink.java
##########
@@ -77,7 +79,11 @@ public void open(Configuration parameters) throws Exception {
writeParallelSize =
getRuntimeContext().getExecutionConfig().getParallelism();
// writeClient
- writeClient = new HoodieFlinkWriteClient<>(new
HoodieFlinkEngineContext(new FlinkTaskContextSupplier(null)),
StreamerUtil.getHoodieClientConfig(cfg));
Review comment:
I saw the description of the Jira issue. It seems
`StreamerUtil.getHoodieClientConfig(cfg)` also invokes
`FlinkOptions.fromStreamerConfig(conf)` firstly, then call `public static
HoodieWriteConfig getHoodieClientConfig(Configuration conf)`. Why your change
can fix the NPE?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
