hudi-agent commented on code in PR #18689:
URL: https://github.com/apache/hudi/pull/18689#discussion_r3189331541
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KinesisReadConfig.java:
##########
@@ -41,12 +42,17 @@ public class KinesisReadConfig implements Serializable {
private final String accessKey; // null if not set
private final String secretKey; // null if not set
private final KinesisSourceConfig.KinesisStartingPositionStrategy
startingPosition;
+ @Getter(AccessLevel.NONE)
Review Comment:
🤖 nit: could you rename the field to `metaFieldsEnabled` (mirroring
`deaggregationEnabled`) and let Lombok generate `isMetaFieldsEnabled()`
automatically? That would let you drop the `@Getter(AccessLevel.NONE)`
suppression and the hand-written getter below, keeping the boolean accessor
style consistent across the class.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
