vburenin commented on pull request #2500:
URL: https://github.com/apache/hudi/pull/2500#issuecomment-778309343


   > yeah, that's what I initially thought. but wasn't sure if we need to do 
two checks
   > 
   > ```
   > if(fsDataInputStream.getWrappedStream() instance of FSDataInputStream && 
((FSDataInputStream)fsDataInputStream.getWrappedStream()).getWrappedStream() 
instance of FSInputStream)
   > ```
   > 
   > hence, thought will use catch block to fallback which might be easier for 
readability.
   
   Agreed. LGTM.
   However, I have no way to approve it. My permissions for the projects are 
still almost R/O ;)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to