linliu-code commented on code in PR #18385:
URL: https://github.com/apache/hudi/pull/18385#discussion_r3191104207
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/CloudSourceConfig.java:
##########
@@ -181,4 +181,28 @@ public class CloudSourceConfig extends HoodieConfig {
.markAdvanced()
.sinceVersion("1.0.0")
.withDocumentation("Boolean value to allow coalesce alias columns with
actual columns while reading from source");
+
+ public static final ConfigProperty<Boolean> CLOUD_INCREMENTAL_MERGE_SCHEMA =
ConfigProperty
+ .key(STREAMER_CONFIG_PREFIX + "source.cloud.data.merge.schema.enable")
+ .defaultValue(true)
+ .withAlternatives(
+ DELTA_STREAMER_CONFIG_PREFIX +
"source.cloud.data.merge.schema.enable",
+ // Back-compat aliases: an earlier iteration of this PR used a
`merge_schema` (underscore)
+ // form and an earlier dot-style `merge.schema` form, plus the
original parquet-only key.
+ // All four are still honored.
+ STREAMER_CONFIG_PREFIX + "source.cloud.data.merge_schema.enable",
+ DELTA_STREAMER_CONFIG_PREFIX +
"source.cloud.data.merge_schema.enable",
+ STREAMER_CONFIG_PREFIX + "source.cloud.data.merge.schema",
+ DELTA_STREAMER_CONFIG_PREFIX + "source.cloud.data.merge.schema",
+ STREAMER_CONFIG_PREFIX + "source.cloud.data.parquet.merge.schema",
+ DELTA_STREAMER_CONFIG_PREFIX +
"source.cloud.data.parquet.merge.schema")
Review Comment:
We don't need these alternative configs, since this PR is never merged and
used by any code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
