oglego opened a new pull request, #18693: URL: https://github.com/apache/hudi/pull/18693
### Describe the issue this Pull Request addresses Closes #14486 Enables the rollback case in `TestHoodieRealtimeRecordReader.testReader` and removes the TODO comment added in PR-674: ```java // TODO: HUDI-154 Once Hive 2.x PR (PR-674) is merged, enable this change // logVersionsWithAction.add(Pair.of(HoodieTimeline.ROLLBACK_ACTION, 3)); ``` JIRA: https://issues.apache.org/jira/browse/HUDI-154 ### Summary and Changelog Uncomments and fixes the rollback test case in `TestHoodieRealtimeRecordReader.testReader`. Three changes were made to enable the rollback case: 1. Uncommented `logVersionsWithAction.add(Pair.of(HoodieTimeline.ROLLBACK_ACTION, 3))` to enable the rollback iteration. 2. Added proper rollback timeline entry using `createRequestedRollbackFile` instead of `createDeltaCommit` for the rollback action, so the timeline correctly records the rollback. 3. `HoodieRealtimeFileSplit` was constructed with `latestInstant` (the last valid commit) instead of `instantTime` (the rollback instant), so the reader correctly stops at the last valid commit. ### Impact None. Test-only change with no public API or user-facing impact. ### Risk Level None. Test-only change. ### Documentation Update None. ### Contributor's checklist - [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute) - [x] Enough context is provided in the sections above - [x] Adequate tests were added if applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
