hudi-agent commented on code in PR #18690: URL: https://github.com/apache/hudi/pull/18690#discussion_r3193289661
########## hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bootstrap/RLIBootstrapOperator.java: ########## Review Comment: 🤖 **Line 71:** Could you double-check the ordering here? `preLoadRLIRecords()` ends by calling `closeMetadataTable()` (line 125), and `closeMetadataTable()` sets `this.metadataTable = null` (line 153). So by the time this line runs, `metadataTable` is null and `FlinkMetricsUtils.registerMetadataTableMetrics` short-circuits via its `if (metadataTable == null) return result;` early-return — no metrics actually get bridged for `RLIBootstrapOperator`. Would moving the registration call inside `preLoadRLIRecords()` just before the `closeMetadataTable()` line, or pulling that close out of `preLoadRLIRecords()` so it runs after the registration, work? (the operator's `close()` method already calls `closeMetadataTable()` as a fallback.) <sub><i>- AI-generated; verify before applying. React 👍/👎 to flag quality.</i></sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
