This is an automated email from the ASF dual-hosted git repository.
vinoyang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hudi.git
The following commit(s) were added to refs/heads/master by this push:
new 527175a [MINOR] Default to empty list for unset datadog tags property
(#2574)
527175a is described below
commit 527175ab0be59d15f035a09a0466bfeca9abfb23
Author: Raymond Xu <[email protected]>
AuthorDate: Fri Feb 12 23:52:03 2021 -0800
[MINOR] Default to empty list for unset datadog tags property (#2574)
---
.../org/apache/hudi/config/HoodieWriteConfig.java | 2 +-
.../datadog/TestHoodieMetricsDatadogConfig.java | 39 ++++++++++++++++++++++
2 files changed, 40 insertions(+), 1 deletion(-)
diff --git
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
index 3fc5a2d..cadb2d1 100644
---
a/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
+++
b/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java
@@ -767,7 +767,7 @@ public class HoodieWriteConfig extends DefaultHoodieConfig {
public List<String> getDatadogMetricTags() {
return Arrays.stream(props.getProperty(
-
HoodieMetricsDatadogConfig.DATADOG_METRIC_TAGS).split("\\s*,\\s*")).collect(Collectors.toList());
+ HoodieMetricsDatadogConfig.DATADOG_METRIC_TAGS,
",").split("\\s*,\\s*")).collect(Collectors.toList());
}
public String getMetricReporterClassName() {
diff --git
a/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestHoodieMetricsDatadogConfig.java
b/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestHoodieMetricsDatadogConfig.java
new file mode 100644
index 0000000..d0fa413
--- /dev/null
+++
b/hudi-client/hudi-client-common/src/test/java/org/apache/hudi/metrics/datadog/TestHoodieMetricsDatadogConfig.java
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.metrics.datadog;
+
+import org.apache.hudi.config.HoodieMetricsDatadogConfig;
+import org.apache.hudi.config.HoodieWriteConfig;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+import static org.junit.jupiter.api.Assertions.assertIterableEquals;
+
+public class TestHoodieMetricsDatadogConfig {
+
+ @Test
+ public void getDatadogMetricTagsShouldReturnEmptyListWhenNotSet() {
+ HoodieWriteConfig writeConfig =
HoodieWriteConfig.newBuilder().withPath("/tmp").build();
+
writeConfig.getProps().remove(HoodieMetricsDatadogConfig.DATADOG_METRIC_TAGS);
+ assertIterableEquals(Collections.emptyList(),
writeConfig.getDatadogMetricTags());
+ }
+}
