hudi-agent commented on code in PR #18535:
URL: https://github.com/apache/hudi/pull/18535#discussion_r3195694639
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestVectorDataSource.scala:
##########
@@ -674,6 +677,263 @@ class TestVectorDataSource extends
HoodieSparkClientTestBase {
assertTrue(r7.getSeq[Double](1).forall(_ == 1.0), "key_7 should have
original value 1.0")
}
+ @Test
+ def testMorLogOnlyCompactionPreservesVectorMetadata(): Unit = {
Review Comment:
🤖 nit: `testMorLogOnlyCompactionPreservesVectorMetadata` and
`testMorLogOnlyCompactionPreservesVectorMetadataLance` are ~120 lines of
near-identical body that differ only in the `hoodie.table.base.file.format =
LANCE` tblproperty (plus the extra Lance base-file assertion at the end). Could
you extract a shared private helper that takes the format as a parameter, or
use `@ParameterizedTest` so the body lives in one place?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
