yanghua commented on a change in pull request #2534:
URL: https://github.com/apache/hudi/pull/2534#discussion_r575786145



##########
File path: 
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
##########
@@ -645,4 +625,55 @@ public void setMetaPath(String metaPath) {
   public void setActiveTimeline(HoodieActiveTimeline activeTimeline) {
     this.activeTimeline = activeTimeline;
   }
+

Review comment:
       IMO, if we have a **static** method, like this:
   
   ```java
   public static Builder builder() {
           return new Builder();
   }
   ```
   
   Then, we can use it via this style:
   
   ```
   HoodieTableMetaClient.builder().setXXX().setXXX()....build();
   ```
   
   It will make the call chain more readable. wdyt?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to