danny0405 commented on code in PR #18697:
URL: https://github.com/apache/hudi/pull/18697#discussion_r3198773885
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java:
##########
@@ -78,8 +80,8 @@ public HiveSyncTool hiveSyncTool() {
HiveSyncMode syncMode =
HiveSyncMode.of(props.getProperty(HIVE_SYNC_MODE.key()));
if (syncMode == HiveSyncMode.GLUE) {
return ((HiveSyncTool)
ReflectionUtils.loadClass(AWS_GLUE_CATALOG_SYNC_TOOL_CLASS,
- new Class<?>[] {Properties.class,
org.apache.hadoop.conf.Configuration.class},
- props, hiveConf));
+ new Class<?>[] {Properties.class,
org.apache.hadoop.conf.Configuration.class, Option.class},
+ props, hiveConf, Option.<HoodieTableMetaClient>empty()));
Review Comment:
do you think we can write a simple UT of `HiveSyncContext` to validate the
instantiation of the `AWS_GLUE_CATALOG_SYNC_TOOL_CLASS` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
