hudi-agent commented on code in PR #18697:
URL: https://github.com/apache/hudi/pull/18697#discussion_r3199881125
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/utils/HiveSyncContext.java:
##########
@@ -78,8 +80,8 @@ public HiveSyncTool hiveSyncTool() {
HiveSyncMode syncMode =
HiveSyncMode.of(props.getProperty(HIVE_SYNC_MODE.key()));
if (syncMode == HiveSyncMode.GLUE) {
return ((HiveSyncTool)
ReflectionUtils.loadClass(AWS_GLUE_CATALOG_SYNC_TOOL_CLASS,
- new Class<?>[] {Properties.class,
org.apache.hadoop.conf.Configuration.class},
- props, hiveConf));
+ new Class<?>[] {Properties.class,
org.apache.hadoop.conf.Configuration.class, Option.class},
+ props, hiveConf, Option.<HoodieTableMetaClient>empty()));
Review Comment:
🤖 nit: the `<HoodieTableMetaClient>` type witness isn't needed here —
`ReflectionUtils.loadClass` takes `Object...` args, so `Option.empty()` works
fine and would also let you drop the `HoodieTableMetaClient` import that was
added solely for this.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
