hudi-agent commented on code in PR #18707:
URL: https://github.com/apache/hudi/pull/18707#discussion_r3208792636
##########
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java:
##########
@@ -532,6 +533,21 @@ && getTable(awsGlue, databaseName,
tableName).partitionKeys().equals(partitionKe
}
}
+ @Override
+ public void updateHoodieWriterVersion(String tableName) {
+ try {
+ updateTableParameters(
+ awsGlue,
+ databaseName,
+ tableName,
+ Collections.singletonMap(HoodieVersion.HOODIE_WRITER_VERSION,
HoodieVersion.get()),
+ skipTableArchive);
+ } catch (Exception e) {
+ throw new HoodieGlueSyncException(String.format("Failed to update hudi
writer major version %s for %s",
Review Comment:
🤖 nit: the error message says "hudi writer **major** version" but
`HoodieVersion.get()` returns the full version string (e.g. `0.14.0`), not just
the major. Could you drop "major" here? Also, could you swap "hudi" for
"Hoodie" to stay consistent with the codebase convention?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
