danny0405 commented on code in PR #17517:
URL: https://github.com/apache/hudi/pull/17517#discussion_r3213177685
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/functional/TestHoodieLogFormat.java:
##########
@@ -215,7 +215,7 @@ public void testEmptyLog() throws IOException {
@EnumSource(names = {"AVRO_DATA_BLOCK", "HFILE_DATA_BLOCK",
"PARQUET_DATA_BLOCK"})
public void testBasicAppend(HoodieLogBlockType dataBlockType) throws
IOException, InterruptedException, URISyntaxException {
Writer writer =
- HoodieLogFormat.newWriterBuilder().onParentPath(partitionPath)
+
HoodieLogFormat.newWriterBuilder().onParentPath(partitionPath).withSyncDuringFlush(true)
Review Comment:
if it is okay we also call the hsync once during `closeStream` for 0.x
table, can we add an explicit hsync api on the writer just for the tests? I see
the tests are logging `auto-flushed` keywords, we might remove the auto-flush
totally since it impacts the perf. We just need to ensure visibility for commit
level to downstream instead of per log block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
