cshuo commented on code in PR #18712:
URL: https://github.com/apache/hudi/pull/18712#discussion_r3215850074


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/DataTypeUtils.java:
##########
@@ -271,4 +277,28 @@ public static List<String> getMetadataColumns(Schema 
schema) {
           }
         }).map(Schema.UnresolvedColumn::getName).collect(Collectors.toList());
   }
+
+  /**
+   * Validates that the required row data type only projects data types 
supported by Flink source reads.
+   */
+  public static void validateReaderSupportedDataTypes(HoodieSchema 
tableSchema, DataType requiredDataType) {

Review Comment:
   Mapping VECTOR type silently to ARRAY would cause cryptic decoding errors at 
read time. Besides, failing early during pipeline construction avoids 
scheduling and running the pipeline unnecessarily, which is lighter weight. 
Once VECTOR read support is ready, we can simply remove this guard.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to