1fanwang opened a new pull request, #18721:
URL: https://github.com/apache/hudi/pull/18721

   ## Describe the issue this Pull Request addresses
   
   Closes #17105 / [HUDI-9624](https://issues.apache.org/jira/browse/HUDI-9624).
   
   When a user sets `hoodie.payload.event.time.field` to opt into event-time 
semantics but leaves `hoodie.write.track.event.time.watermark` at its default 
`false`, event-time watermark metadata is silently absent from commit metadata. 
The user gets no signal that their intent to track event time was dropped.
   
   ## Summary and Changelog
   
   - `HoodieWriteConfig.Builder.validate()`: warn when the user has configured 
an event-time field but not enabled watermark tracking. The warning names both 
keys and tells the user how to opt in.
   - `TestHoodieWriteConfig`: three new tests cover (a) warning fires when only 
the event-time field is set, (b) no warning when both keys are set, (c) no 
warning when neither is set.
   
   ## Impact
   
   Strictly informational — no behavior change to commit metadata, no new 
exceptions thrown. Fires once per `HoodieWriteConfig` build, alongside the 
existing advisory warnings in `validate()`.
   
   ## Risk Level
   
   Low. The check reads only write-config properties (no meta-client access). 
All 42 tests in `TestHoodieWriteConfig` pass (39 existing + 3 new).
   
   ## Documentation Update
   
   Not required — the warning itself is self-documenting and points the user at 
the existing config key.
   
   ## Contributor's checklist
   
   - [x] Read through contributor's guide
   - [x] Enough context is provided
   - [x] Adequate tests were added


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to