wombatu-kun commented on code in PR #18375:
URL: https://github.com/apache/hudi/pull/18375#discussion_r3224854019
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/HoodieIndexUtils.java:
##########
@@ -251,8 +251,13 @@ public static Collection<Pair<String, Long>>
filterKeysFromFile(StoragePath file
return Collections.emptyList();
}
log.info("Going to filter {} keys from file {}",
candidateRecordKeys.size(), filePath);
+ // TODO: The AVRO fallback here ignores the merger's configured type. This
pre-dates
+ // the Lance PR and is tracked at
https://github.com/apache/hudi/issues/18496 — respect the
+ // merger's record type for all formats.
+ HoodieRecord.HoodieRecordType recordType =
HoodieFileFormat.resolveRecordTypeForExtension(
+ FSUtils.getFileExtension(filePath.toString()),
HoodieRecord.HoodieRecordType.AVRO);
Review Comment:
Done in 4bb5b0f2d2a8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
