hudi-agent commented on code in PR #18535:
URL: https://github.com/apache/hudi/pull/18535#discussion_r3238464784
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiPageSource.java:
##########
@@ -115,8 +125,32 @@ public long getMemoryUsage()
public void close()
throws IOException
{
- fileGroupReader.close();
- pageSource.close();
+ IOException closeException = null;
+
+ recordIterator.close();
Review Comment:
🤖 Tracing through `CloseableMappingIterator.close()` →
`HoodieFileGroupReaderIterator.close()` → `reader.close()`,
`recordIterator.close()` already invokes `fileGroupReader.close()`. The
subsequent explicit `fileGroupReader.close()` here is therefore a double-close
on the same `baseFileIterator`/`recordBuffer` (HoodieFileGroupReader doesn't
null them out after closing). Should the explicit `fileGroupReader.close()` be
removed, or `recordIterator.close()` be the one that's dropped?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
