hudi-agent commented on code in PR #18743:
URL: https://github.com/apache/hudi/pull/18743#discussion_r3249899630
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/common/AbstractStreamWriteFunction.java:
##########
@@ -176,6 +176,15 @@ public void endInput() {
this.inputEnded = true;
}
+ @Override
+ public void close() throws Exception {
+ super.close();
+ if (this.writeClient != null) {
+ this.writeClient.close();
+ }
+ super.close();
+ }
Review Comment:
🤖 Looking at the current diff, `super.close()` is only invoked once — at the
end of the new `close()` method after `writeClient.close()`. There's no
duplicate call. The try/finally suggestion from the sibling comment still seems
worth considering though, so `super.close()` isn't skipped if
`writeClient.close()` throws.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
