lhjzmn commented on a change in pull request #2532:
URL: https://github.com/apache/hudi/pull/2532#discussion_r579912713
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -64,32 +56,23 @@
public class HoodieHiveClient extends AbstractSyncHoodieClient {
private static final String HOODIE_LAST_COMMIT_TIME_SYNC =
"last_commit_time_sync";
- private static final String HIVE_ESCAPE_CHARACTER =
HiveSchemaUtil.HIVE_ESCAPE_CHARACTER;
private static final Logger LOG =
LogManager.getLogger(HoodieHiveClient.class);
private final PartitionValueExtractor partitionValueExtractor;
private IMetaStoreClient client;
private HiveSyncConfig syncConfig;
private FileSystem fs;
- private Connection connection;
private HoodieTimeline activeTimeline;
- private HiveConf configuration;
public HoodieHiveClient(HiveSyncConfig cfg, HiveConf configuration,
FileSystem fs) {
super(cfg.basePath, cfg.assumeDatePartitioning,
cfg.useFileListingFromMetadata, cfg.verifyMetadataFileListing, fs);
this.syncConfig = cfg;
this.fs = fs;
- this.configuration = configuration;
- // Support both JDBC and metastore based implementations for backwards
compatiblity. Future users should
- // disable jdbc and depend on metastore client for all hive registrations
- if (cfg.useJdbc) {
Review comment:
For Hive synchronization, any JDBC-related code and configuration have
not been used after this change, so this content is removed from
HoodieHiveClient.java. Welcome to continue the discussion @satishkotha
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
