HuangZhenQiu commented on code in PR #18762:
URL: https://github.com/apache/hudi/pull/18762#discussion_r3258864787


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/partitioner/DynamicBucketAssignFunction.java:
##########
@@ -65,6 +66,7 @@ public class DynamicBucketAssignFunction
 
   private transient PartitionedIndexBackend indexBackend;
   private transient BucketAssigner bucketAssigner;
+  private transient FlinkBucketAssignMetrics metrics;

Review Comment:
   The metrics for DynamicBucketAssignFunction can be added in follow up PR. 
But the metrics registration here probably may be added here. @shortly How do 
you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to