yihua commented on PR #18599: URL: https://github.com/apache/hudi/pull/18599#issuecomment-4482928060
> @voonhous @yihua I am thinking we should punt on this PR for now. The rational is that I am not sure if we should dictate how Lance will handle implementing VARIANT support within their file format. Currently this PR's implementation is essentially following the parquet spec, however there is a google doc proposal around the following variant spec in lance: https://docs.google.com/document/d/1aXEoVlRYUMTIQ290Th-sL0kFy0-zwKhe5AKuYzXwjDc/edit?tab=t.0 If Lance does not support variant type natively yet, let's add a simple guard to check write schema and fail fast if the schema contains a variant-typed column and the file format is Lance. In such a case, the user-friendly error message is thrown instead of failing at the Arrow conversion layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
