[GitHub] [hudi] lamber-ken edited a comment on pull request #2593: [HUDI-1632] Supports merge on read write mode for Flink writer

Tue, 23 Feb 2021 02:13:42 -0800 


lamber-ken edited a comment on pull request #2593:
URL: https://github.com/apache/hudi/pull/2593#issuecomment-784070273


   hi @danny0405 thank for the patch, several checkstyle errors，use command to 
check `mvn checkstyle:check`
   
   Change junit4 to junit5
   
   ```
   import org.junit.Ignore;  -->  import org.junit.jupiter.api.Disabled;
   ```
   
   And
   
   ```
   [ERROR] 
src/main/java/org/apache/hudi/operator/compact/CompactEvent.java:[35,23] 
(whitespace) MethodParamPad: '(' is preceded with whitespace.
   [ERROR] src/main/java/org/apache/hudi/operator/FlinkOptions.java:[172,67] 
(whitespace) WhitespaceAround: WhitespaceAround: '=' is not preceded with 
whitespace.
   [ERROR] src/main/java/org/apache/hudi/util/StreamerUtil.java:[40,8] 
(imports) UnusedImports: Unused import - 
org.apache.hudi.table.action.compact.strategy.CompactionStrategy.
   
   ```
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to