hudi-agent commented on code in PR #18786:
URL: https://github.com/apache/hudi/pull/18786#discussion_r3271004563
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##########
@@ -66,8 +66,7 @@ object HoodieAnalysis extends SparkAdapterSupport {
} else if (HoodieSparkUtils.isSpark3_4) {
"org.apache.spark.sql.hudi.analysis.HoodieSpark34DataSourceV2ToV1Fallback"
} else {
- // Spark 3.3.x
-
"org.apache.spark.sql.hudi.analysis.HoodieSpark33DataSourceV2ToV1Fallback"
+ throw new IllegalStateException("Unsupported Spark version")
Review Comment:
🤖 nit: could you include the actual version here (and at the two similar
throws on lines ~153 and ~174) to match what `SparkAdapterSupport` does?
Something like `s"Unsupported Spark version:
${HoodieSparkUtils.getSparkVersion}"` would make the error a lot easier to
diagnose in the wild.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/sources/helpers/TestMercifulJsonToRowConverterBase.java:
##########
@@ -356,25 +355,7 @@ public interface ThrowingRunnable {
}
Review Comment:
🤖 nit: now that the Spark 3.3 workaround is gone,
`timestampNTZCompatibility` just calls `r.run()` — the name implies a
compatibility shim that no longer exists, which could confuse a future reader.
Could you inline it at the call sites or rename it to something that still
carries meaning (e.g. `runWithTimestampNTZ`)?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
