hudi-agent commented on code in PR #18789:
URL: https://github.com/apache/hudi/pull/18789#discussion_r3272523390
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/StreamWriteOperatorCoordinator.java:
##########
@@ -759,7 +759,7 @@ private static class TableState implements Serializable {
final boolean syncMetadata;
final boolean isDeltaTimeCompaction;
final boolean isStreamingIndexWriteEnabled;
- final boolean isRLIWithBootstrap;
+ final boolean isRecordLevelIndex;
Review Comment:
🤖 nit: could you rename `isRecordLevelIndex` to something like
`isAnyRecordLevelIndex`? The field name is identical to
`OptionsResolver.isRecordLevelIndex()`, which only covers one of the two
variants, so a reader scanning the constructor assignment on the next screen
(`isGlobalRecordLevelIndex || isRecordLevelIndex`) may have to stop and work
out that the field is a broader OR of both.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
