cshuo commented on code in PR #18761:
URL: https://github.com/apache/hudi/pull/18761#discussion_r3274000896
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/metrics/FlinkIndexBackendMetrics.java:
##########
@@ -63,6 +76,22 @@ public void registerMetrics() {
metricGroup.histogram("remoteIndexLookupLatency",
remoteIndexLookupLatency);
metricGroup.histogram("localLookupKeysNum", localLookupKeysNum);
metricGroup.histogram("remoteLookupKeysNum", remoteLookupKeysNum);
+ metricGroup.counter(BUCKET_ASSIGN_MINIBATCH_CACHE_HIT_COUNT,
cacheHitCount);
+ metricGroup.counter(BUCKET_ASSIGN_MINIBATCH_CACHE_MISS_COUNT,
cacheMissCount);
Review Comment:
We already have `localLookupKeysNum` and `remoteLookupKeysNum`, can we can
add a hit ratio gauge metric , like 'lookupCacheHitRatio' based on these two
fields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
