CTTY commented on code in PR #18786:
URL: https://github.com/apache/hudi/pull/18786#discussion_r3278654805
##########
packaging/bundle-validation/ci_run.sh:
##########
@@ -116,12 +106,17 @@ elif [[ ${SPARK_RUNTIME} == 'spark3.5.1' &&
${SCALA_PROFILE} == 'scala-2.13' ]];
HADOOP_VERSION=3.3.5
HIVE_VERSION=3.1.3
DERBY_VERSION=10.14.1.0
- FLINK_VERSION=1.20.1
SPARK_VERSION=3.5.1
SPARK_HADOOP_VERSION=3
CONFLUENT_VERSION=5.5.12
KAFKA_CONNECT_HDFS_VERSION=10.1.13
- IMAGE_TAG=flink1200hive313spark351scala213
+ if [[ ${FLINK_PROFILE} == 'flink1.19' ]]; then
+ IMAGE_TAG=flink1190hive313spark351scala213
+ FLINK_VERSION=1.19.0
+ else
+ IMAGE_TAG=flink1200hive313spark351scala213
+ FLINK_VERSION=1.20.1
+ fi
Review Comment:
why is this change needed?
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala:
##########
@@ -101,12 +98,8 @@ object HoodieAnalysis extends SparkAdapterSupport {
"org.apache.spark.sql.hudi.Spark40ResolveHudiAlterTableCommand"
} else if (HoodieSparkUtils.gteqSpark3_5) {
"org.apache.spark.sql.hudi.Spark35ResolveHudiAlterTableCommand"
- } else if (HoodieSparkUtils.isSpark3_4) {
- "org.apache.spark.sql.hudi.Spark34ResolveHudiAlterTableCommand"
- } else if (HoodieSparkUtils.isSpark3_3) {
- "org.apache.spark.sql.hudi.Spark33ResolveHudiAlterTableCommand"
} else {
- throw new IllegalStateException("Unsupported Spark version")
+ "org.apache.spark.sql.hudi.Spark34ResolveHudiAlterTableCommand"
Review Comment:
We are silently falling back to spark 34 here. I think we should still throw
the exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
