shangxinli commented on code in PR #18765:
URL: https://github.com/apache/hudi/pull/18765#discussion_r3283584805
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodiePreCommitValidatorConfig.java:
##########
@@ -46,7 +46,9 @@ public class HoodiePreCommitValidatorConfig extends
HoodieConfig {
.withDocumentation("Comma separated list of class names that can be
invoked to validate commit. "
+ "Available streaming offset validators: "
+ "org.apache.hudi.sink.validator.FlinkKafkaOffsetValidator (Flink
Kafka), "
- +
"org.apache.hudi.utilities.streamer.validator.SparkKafkaOffsetValidator
(Spark/HoodieStreamer Kafka)");
+ +
"org.apache.hudi.utilities.streamer.validator.SparkKafkaOffsetValidator
(Spark/HoodieStreamer Kafka). "
+ + "Available write-error validators: "
+ +
"org.apache.hudi.utilities.streamer.validator.SparkWriteErrorValidator
(Spark/HoodieStreamer write errors).");
Review Comment:
To make sure I read this right — are you suggesting we should auto-configure
it by default? Currently it's opt-in via hoodie.precommit.validators, and the
inline Step 4 gate in StreamSync preserves the HSWSV commitOnErrors default
behavior either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
