hudi-agent commented on code in PR #18817:
URL: https://github.com/apache/hudi/pull/18817#discussion_r3288365380
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockProvider.java:
##########
@@ -109,7 +110,7 @@ public class StorageBasedLockProvider implements
LockProvider<StorageLockFile> {
private final transient Thread shutdownThread;
private final Option<HoodieLockMetrics> hoodieLockMetrics;
private Option<AuditService> auditService;
- private final String basePath;
+ private final String normalizedHudiTableBasePath;
Review Comment:
🤖 nit: `normalizedHudiTableBasePath` feels a bit verbose — within a class
that's exclusively a Hudi table lock provider, the `HudiTable` infix is
redundant context. Could you shorten to `normalizedBasePath`? Same pattern
applies in `ZookeeperBasedImplicitBasePathLockProvider` and
`DynamoDBBasedImplicitPartitionKeyLockProvider`.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
