Davis-Zhang-Onehouse commented on PR #18814: URL: https://github.com/apache/hudi/pull/18814#issuecomment-4523374761
Pushed bbdbee2 to narrow the scheme-only rejection in `normalizeBasePathForLocking`. The previous heuristic — `charAt(end - 1) == ':'` after stripping trailing slashes — silently rejected any input whose final character was `:`, including legitimate S3 keys like `s3://bucket/foo:/` or `s3://bucket/foo:bar:/`. S3 object keys are allowed to contain `:`, so this was a behavior regression vs the pre-PR `s3aToS3`-only code. The new check rejects only when the stripped form ends with `:` AND has no `/` character remaining. Scheme-only inputs (`s3://`, `s3a:///`) collapse to `<scheme>:` with no `/` and are still rejected; real paths retain the `/` characters from the `://` separator and pass through. Added test coverage for both the new accept-path and the still-rejected scheme-only cases. (Caught by @yihua during review of the downstream Onehouse cherry-pick.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
