danny0405 commented on a change in pull request #2593:
URL: https://github.com/apache/hudi/pull/2593#discussion_r584410935
##########
File path: hudi-flink/src/main/java/org/apache/hudi/operator/FlinkOptions.java
##########
@@ -165,6 +165,42 @@ private FlinkOptions() {
.defaultValue(128D) // 128MB
.withDescription("Batch buffer size in MB to flush data into the
underneath filesystem");
+ // ------------------------------------------------------------------------
+ // Compaction Options
+ // ------------------------------------------------------------------------
+
+ public static final ConfigOption<Boolean> WRITE_ASYNC_COMPACTION =
ConfigOptions
+ .key("compaction.async.enabled")
+ .booleanType()
+ .defaultValue(true) // default true for MOR write
+ .withDescription("Async Compaction, enabled by default for MOR");
+
+ public static final String NUM_COMMITS = "num_commits";
+ public static final String TIME_ELAPSED = "time_elapsed";
+ public static final String NUM_AND_TIME = "num_and_time";
+ public static final String NUM_OR_TIME = "num_or_time";
+ public static final ConfigOption<String> COMPACTION_TRIGGER_STRATEGY =
ConfigOptions
+ .key("compaction.trigger.strategy")
Review comment:
No, the option key of `HoodieCompactionConfig` is too long and not very
friendly to use as SQL options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
