nsivabalan commented on code in PR #18834:
URL: https://github.com/apache/hudi/pull/18834#discussion_r3301557212
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/SpillableMapBasedFileSystemView.java:
##########
@@ -225,14 +225,18 @@ protected void
removeReplacedFileIdsAtInstants(Set<String> instants) {
}
@Override
- public void close() {
+ protected void closeResources() throws Exception {
Review Comment:
should we make similar fixes to RocksDbBasedFSV as well?
```
@Override
public void close() {
try {
LOG.info("Closing Rocksdb !!");
closed = true;
closeResources();
rocksDB.close();
LOG.info("Closed Rocksdb !!");
} catch (Exception e) {
throw new HoodieException("Unable to close file system view", e);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
