cshuo opened a new pull request, #18842:
URL: https://github.com/apache/hudi/pull/18842

   ### Describe the issue this Pull Request addresses
   
   Record key configuration parsing was handled independently across key 
generation, index configuration, Flink option resolution, and Spark SQL delete 
logic. These duplicated parsing paths could diverge around trimming, empty 
entries, and field counting, making record-key behavior harder to reason about 
consistently.
   
   This PR centralizes record key field splitting and extraction through 
`KeyGenUtils`, then updates callers to use the shared helper.
   
   ### Summary and Changelog
   
   - Added `KeyGenUtils.getRecordKeyFields(String)` and routed the existing 
`TypedProperties` helper through it.
   - Updated key generator type inference to count parsed record key fields 
using the shared helper.
   - Replaced duplicated record key parsing in `CustomAvroKeyGenerator`, Spark 
`CustomKeyGenerator`, `HoodieIndexConfig`, Flink `OptionsResolver`, and Spark 
3/4 `DeleteHoodieTableCommand`.
   
   ### Impact
   
   Record key parsing is normalized across affected Hudi modules, especially 
for whitespace and empty comma-separated entries, and reduces duplicated 
string-splitting logic and makes future record key parsing changes local to 
`KeyGenUtils`.
   
   ### Risk Level
   low
   
   
   ### Documentation Update
   
   <!-- Describe any necessary documentation update if there is any new 
feature, config, or user-facing change. If not, put "none".
   
   - The config description must be updated if new configs are added or the 
default value of the configs are changed.
   - Any new feature or user-facing change requires updating the Hudi website. 
Please follow the 
     [instruction](https://hudi.apache.org/contribute/developer-setup#website) 
to make changes to the website. -->
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's 
guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to