hudi-agent commented on code in PR #18843:
URL: https://github.com/apache/hudi/pull/18843#discussion_r3301896131
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -691,6 +732,32 @@ protected void flushToDiskIfRequired(HoodieRecord record,
boolean appendDeleteBl
}
}
+ @VisibleForTesting
+ void setSizeEstimator(SizeEstimator<HoodieRecord> sizeEstimator) {
+ this.sizeEstimator = sizeEstimator;
+ }
+
+ @VisibleForTesting
Review Comment:
🤖 nit: could you add the `ForTest` suffix here to match
`getNumberOfRecordsForTest` and `getEstimatedBytesWrittenForTest`? As written,
`getAverageRecordSize()` looks like it might be production API, while the
siblings clearly signal test-only.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
