hudi-agent commented on code in PR #18848:
URL: https://github.com/apache/hudi/pull/18848#discussion_r3304500351
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -295,7 +304,12 @@ public Result inputSplits(
log.warn("No files found for reading under path: {}", path);
return Result.EMPTY;
}
- List<FileSlice> allFileSlices = getFileSlices(metaClient,
commitTimeline, readPartitions, pathInfoList, offsetToIssue, false);
+ // Use the full commits-and-compaction timeline rather than the
(possibly compaction-filtered)
Review Comment:
🤖 nit: this comment block is a verbatim copy of the one at line 187, and the
full explanation is already in `getFullCommitsTimeline()`'s Javadoc. The middle
call site (line 225) gets this right with "Same reason as the full-table-scan
branch above" — could this one follow the same pattern to keep maintenance to
one place?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
