fhan688 commented on code in PR #18848:
URL: https://github.com/apache/hudi/pull/18848#discussion_r3308377086
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -295,7 +304,12 @@ public Result inputSplits(
log.warn("No files found for reading under path: {}", path);
return Result.EMPTY;
}
- List<FileSlice> allFileSlices = getFileSlices(metaClient,
commitTimeline, readPartitions, pathInfoList, offsetToIssue, false);
+ // Use the full commits-and-compaction timeline rather than the
(possibly compaction-filtered)
Review Comment:
Good catch — agreed. Will collapse the duplicated block at the streaming
earliest call site to a short cross-reference pointing to
getFullCommitsTimeline()'s Javadoc (the two call sites live in different
inputSplits overloads, so referencing the helper's Javadoc keeps it unambiguous
rather than using "above").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
