rahil-c commented on code in PR #18797:
URL: https://github.com/apache/hudi/pull/18797#discussion_r3313216176
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/HoodieVectorSearchTableValuedFunction.scala:
##########
@@ -106,6 +115,37 @@ object HoodieVectorSearchTableValuedFunction {
}
kValue
}
+
+ /** Parses a string argument that may be NULL (meaning "not specified"). */
+ private[logical] def parseOptionalString(
+ funcName: String, expr: Expression, argName: String): Option[String] =
expr match {
+ case Literal(null, _) => None
+ case Literal(v, StringType) if v != null =>
+ val s = v.toString.trim
+ if (s.isEmpty) None else Some(s)
+ case _ => throw new HoodieAnalysisException(
+ s"Function '$funcName': argument '$argName' must be a string literal or
NULL, got: ${expr.sql}")
+ }
+
+ /**
+ * Parses a numeric argument that may be NULL (meaning "not specified").
Accepts
+ * any foldable expression of [[NumericType]] (or [[NullType]] for an untyped
+ * NULL keyword) — including a bare literal or {@code CAST(literal AS
numeric)} —
+ * and widens to Double. String literals are rejected even when their
contents
+ * happen to parse as a number, so the type contract surfaces at parse time.
+ */
+ private[logical] def parseOptionalDouble(
+ funcName: String, expr: Expression, argName: String): Option[Double] = {
+ val numericOrNull = expr.dataType match {
+ case _: NumericType | NullType => true
+ case _ => false
+ }
+ if (!expr.foldable || !numericOrNull) {
+ throw new HoodieAnalysisException(
+ s"Function '$funcName': argument '$argName' must be a numeric literal
or NULL, got: ${expr.sql}")
+ }
+ Option(expr.eval()).map(_.toString.toDouble)
Review Comment:
Let me fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
