hudi-agent commented on code in PR #18873:
URL: https://github.com/apache/hudi/pull/18873#discussion_r3316642752
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/io/storage/row/RowDataParquetWriteSupport.java:
##########
@@ -41,8 +43,9 @@ public class RowDataParquetWriteSupport extends
WriteSupport<RowData> {
private ParquetRowDataWriter writer;
protected final Configuration hadoopConf;
- public RowDataParquetWriteSupport(RowType rowType, Configuration config) {
+ public RowDataParquetWriteSupport(HoodieSchema hoodieSchema, Configuration
config) {
Review Comment:
🤖 nit: could you rename `hoodieSchema` to just `schema`? The type
`HoodieSchema` already carries the `Hoodie` prefix, so the parameter name ends
up redundant — and the subclass `HoodieRowDataParquetWriteSupport` uses
`schema` for the same argument, so aligning them would be more consistent.
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
