hudi-agent commented on code in PR #18848:
URL: https://github.com/apache/hudi/pull/18848#discussion_r3317285109
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/source/IncrementalInputSplits.java:
##########
@@ -184,7 +184,12 @@ public Result inputSplits(
return Result.EMPTY;
}
fileInfoList = fileIndex.getFilesInPartitions();
- List<FileSlice> allFileSlices = getFileSlices(metaClient,
commitTimeline, readPartitions, fileInfoList,
analyzingResult.getMaxCompletionTime(), false);
+ // Use the full commits-and-compaction timeline rather than the
(possibly compaction-filtered)
Review Comment:
🤖 nit: this 4-line rationale largely duplicates the javadoc on
`getFullCommitsTimeline()`. Could you trim it (and the similar comment around
line 224) down to a one-liner like the third call site already does (`see
getFullCommitsTimeline() for why ...`), so the reasoning lives in one place?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
