voonhous commented on code in PR #18867:
URL: https://github.com/apache/hudi/pull/18867#discussion_r3315875042
##########
website/docs/blob_unstructured_data.md:
##########
@@ -158,7 +159,8 @@ INSERT INTO media_assets VALUES (
'reference', named_struct(
'external_path', 's3://my-bucket/media/container_001.bin',
'offset', 8388608, -- byte offset in the container
- 'length', 1073741824 -- number of bytes
+ 'length', 1073741824, -- number of bytes
+ 'managed', false -- Hudi does not manage this
external file
Review Comment:
I think i might have a different mental model from what y'all have.
- `managed=true`: Cleaner **WILL** delete orphaned blobs/files if they are
no longer referenced
- `managed=false`: Cleaner **WILL NOT** delete the orphaned blobs/files.
And managed is only relevant to `OUT_OF_LINE` blobs right?
Nonetheless, this flag is not really used now, we just need to let users
know what they are. Future blob cleaner implementation requires this flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
