hudi-agent commented on code in PR #18892:
URL: https://github.com/apache/hudi/pull/18892#discussion_r3336343473
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/deser/KafkaAvroSchemaDeserializer.java:
##########
@@ -58,6 +59,21 @@ public void configure(Map<String, ?> configs, boolean isKey)
{
}
}
+ @Override
+ public Object deserialize(String s, byte[] bytes) {
Review Comment:
🤖 nit: the parameter `s` in these two overloads is cryptic — the third
override on line 72 correctly uses `topic`, which is also what the parent class
uses. Could you rename `s` to `topic` in both for consistency?
<sub><i>- AI-generated; verify before applying. React 👍/👎 to flag
quality.</i></sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
