voonhous commented on code in PR #18837:
URL: https://github.com/apache/hudi/pull/18837#discussion_r3340114462
##########
hudi-trino-plugin/src/main/java/io/trino/plugin/hudi/HudiSplitSource.java:
##########
@@ -104,9 +104,24 @@ public HudiSplitSource(
HoodieTableMetaClient metaClient = tableHandle.getMetaClient();
HoodieEngineContext engineContext = new
HoodieLocalEngineContext(metaClient.getStorage().getConf());
- HoodieTableMetadata tableMetadata = HoodieTableMetadata.create(
- engineContext,
- tableHandle.getMetaClient().getStorage(), metadataConfig,
metaClient.getBasePath().toString(), true);
+ HoodieTableMetadata tableMetadata;
Review Comment:
Addressed in 9454f87c. The inlined branch is now a single
`NativeTableMetadataFactory.getInstance().create(engineContext, storage,
metadataConfig, basePath, true)` call, which performs the identical create-MDT
/ check-`isMetadataTableInitialized` /
fall-back-to-`FileSystemBackedTableMetadata` logic (its
`metadataConfig.isEnabled()` check subsumes the old `enableMetadataTable`
branch). Note: there is no static `HoodieTableMetadata.create(...)`; the
factory is the actual entrypoint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
