danny0405 commented on code in PR #18842:
URL: https://github.com/apache/hudi/pull/18842#discussion_r3345826260
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/keygen/KeyGenUtils.java:
##########
@@ -331,13 +329,13 @@ public static KeyGenerator
createKeyGeneratorByClassName(TypedProperties props)
}
public static List<String> getRecordKeyFields(TypedProperties props) {
- return
Option.ofNullable(props.getString(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key(),
null))
- .map(recordKeyConfigValue ->
- Arrays.stream(recordKeyConfigValue.split(","))
- .map(String::trim)
- .filter(s -> !s.isEmpty())
- .collect(Collectors.toList())
- ).orElse(Collections.emptyList());
+ return
getRecordKeyFields(props.getString(KeyGeneratorOptions.RECORDKEY_FIELD_NAME.key(),
null));
+ }
+
+ public static List<String> getRecordKeyFields(String recordKeyConfigValue) {
Review Comment:
recordKeyConfigValue -> recordKeys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
