fhan688 commented on code in PR #18897:
URL: https://github.com/apache/hudi/pull/18897#discussion_r3346622659
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/configuration/OptionsResolver.java:
##########
@@ -258,6 +258,24 @@ public static boolean
isSimpleBucketIndexType(Configuration conf) {
return isBucketIndexType(conf) &&
getBucketEngineType(conf).equals(HoodieIndex.BucketIndexEngineType.SIMPLE);
}
+ /**
+ * Returns whether the simple bucket index should use remote partitioner.
+ */
+ public static boolean enableBucketRemotePartitioner(Configuration conf) {
+ return isSimpleBucketIndexType(conf)
+ && isBucketRemotePartitionerEnabled(conf)
+ && Boolean.parseBoolean(conf.getString(
+ HoodieWriteConfig.EMBEDDED_TIMELINE_SERVER_ENABLE.key(),
Review Comment:
Thanks for the suggestion. I accepted this and removed the dependency on
`hoodie.embed.timeline.server` from the remote bucket partitioner enablement
check.
I also fixed the `HoodieWriteConfig` builder order in `FlinkWriteClients` so
that the call-site flag passed to `getHoodieClientConfig(...)` is applied after
`withProps(...)`. This prevents user-provided DDL options from overriding the
coordinator/client-side timeline service behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
